ArgumentResolverTest.php 9.7 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275
  1. <?php
  2. /*
  3. * This file is part of the Symfony package.
  4. *
  5. * (c) Fabien Potencier <fabien@symfony.com>
  6. *
  7. * For the full copyright and license information, please view the LICENSE
  8. * file that was distributed with this source code.
  9. */
  10. namespace Symfony\Component\HttpKernel\Tests\Controller;
  11. use PHPUnit\Framework\TestCase;
  12. use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
  13. use Symfony\Component\HttpKernel\Controller\ArgumentResolver\DefaultValueResolver;
  14. use Symfony\Component\HttpKernel\Controller\ArgumentResolver\RequestAttributeValueResolver;
  15. use Symfony\Component\HttpKernel\Controller\ArgumentResolver\RequestValueResolver;
  16. use Symfony\Component\HttpKernel\Controller\ArgumentResolver\VariadicValueResolver;
  17. use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface;
  18. use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadataFactory;
  19. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\ExtendingRequest;
  20. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\NullableController;
  21. use Symfony\Component\HttpKernel\Tests\Fixtures\Controller\VariadicController;
  22. use Symfony\Component\HttpFoundation\Request;
  23. class ArgumentResolverTest extends TestCase
  24. {
  25. /** @var ArgumentResolver */
  26. private static $resolver;
  27. public static function setUpBeforeClass()
  28. {
  29. $factory = new ArgumentMetadataFactory();
  30. $argumentValueResolvers = array(
  31. new RequestAttributeValueResolver(),
  32. new RequestValueResolver(),
  33. new DefaultValueResolver(),
  34. new VariadicValueResolver(),
  35. );
  36. self::$resolver = new ArgumentResolver($factory, $argumentValueResolvers);
  37. }
  38. public function testDefaultState()
  39. {
  40. $this->assertEquals(self::$resolver, new ArgumentResolver());
  41. $this->assertNotEquals(self::$resolver, new ArgumentResolver(null, array(new RequestAttributeValueResolver())));
  42. }
  43. public function testGetArguments()
  44. {
  45. $request = Request::create('/');
  46. $request->attributes->set('foo', 'foo');
  47. $controller = array(new self(), 'controllerWithFoo');
  48. $this->assertEquals(array('foo'), self::$resolver->getArguments($request, $controller), '->getArguments() returns an array of arguments for the controller method');
  49. }
  50. public function testGetArgumentsReturnsEmptyArrayWhenNoArguments()
  51. {
  52. $request = Request::create('/');
  53. $controller = array(new self(), 'controllerWithoutArguments');
  54. $this->assertEquals(array(), self::$resolver->getArguments($request, $controller), '->getArguments() returns an empty array if the method takes no arguments');
  55. }
  56. public function testGetArgumentsUsesDefaultValue()
  57. {
  58. $request = Request::create('/');
  59. $request->attributes->set('foo', 'foo');
  60. $controller = array(new self(), 'controllerWithFooAndDefaultBar');
  61. $this->assertEquals(array('foo', null), self::$resolver->getArguments($request, $controller), '->getArguments() uses default values if present');
  62. }
  63. public function testGetArgumentsOverrideDefaultValueByRequestAttribute()
  64. {
  65. $request = Request::create('/');
  66. $request->attributes->set('foo', 'foo');
  67. $request->attributes->set('bar', 'bar');
  68. $controller = array(new self(), 'controllerWithFooAndDefaultBar');
  69. $this->assertEquals(array('foo', 'bar'), self::$resolver->getArguments($request, $controller), '->getArguments() overrides default values if provided in the request attributes');
  70. }
  71. public function testGetArgumentsFromClosure()
  72. {
  73. $request = Request::create('/');
  74. $request->attributes->set('foo', 'foo');
  75. $controller = function ($foo) {};
  76. $this->assertEquals(array('foo'), self::$resolver->getArguments($request, $controller));
  77. }
  78. public function testGetArgumentsUsesDefaultValueFromClosure()
  79. {
  80. $request = Request::create('/');
  81. $request->attributes->set('foo', 'foo');
  82. $controller = function ($foo, $bar = 'bar') {};
  83. $this->assertEquals(array('foo', 'bar'), self::$resolver->getArguments($request, $controller));
  84. }
  85. public function testGetArgumentsFromInvokableObject()
  86. {
  87. $request = Request::create('/');
  88. $request->attributes->set('foo', 'foo');
  89. $controller = new self();
  90. $this->assertEquals(array('foo', null), self::$resolver->getArguments($request, $controller));
  91. // Test default bar overridden by request attribute
  92. $request->attributes->set('bar', 'bar');
  93. $this->assertEquals(array('foo', 'bar'), self::$resolver->getArguments($request, $controller));
  94. }
  95. public function testGetArgumentsFromFunctionName()
  96. {
  97. $request = Request::create('/');
  98. $request->attributes->set('foo', 'foo');
  99. $request->attributes->set('foobar', 'foobar');
  100. $controller = __NAMESPACE__.'\controller_function';
  101. $this->assertEquals(array('foo', 'foobar'), self::$resolver->getArguments($request, $controller));
  102. }
  103. public function testGetArgumentsFailsOnUnresolvedValue()
  104. {
  105. $request = Request::create('/');
  106. $request->attributes->set('foo', 'foo');
  107. $request->attributes->set('foobar', 'foobar');
  108. $controller = array(new self(), 'controllerWithFooBarFoobar');
  109. try {
  110. self::$resolver->getArguments($request, $controller);
  111. $this->fail('->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
  112. } catch (\Exception $e) {
  113. $this->assertInstanceOf('\RuntimeException', $e, '->getArguments() throws a \RuntimeException exception if it cannot determine the argument value');
  114. }
  115. }
  116. public function testGetArgumentsInjectsRequest()
  117. {
  118. $request = Request::create('/');
  119. $controller = array(new self(), 'controllerWithRequest');
  120. $this->assertEquals(array($request), self::$resolver->getArguments($request, $controller), '->getArguments() injects the request');
  121. }
  122. public function testGetArgumentsInjectsExtendingRequest()
  123. {
  124. $request = ExtendingRequest::create('/');
  125. $controller = array(new self(), 'controllerWithExtendingRequest');
  126. $this->assertEquals(array($request), self::$resolver->getArguments($request, $controller), '->getArguments() injects the request when extended');
  127. }
  128. /**
  129. * @requires PHP 5.6
  130. */
  131. public function testGetVariadicArguments()
  132. {
  133. $request = Request::create('/');
  134. $request->attributes->set('foo', 'foo');
  135. $request->attributes->set('bar', array('foo', 'bar'));
  136. $controller = array(new VariadicController(), 'action');
  137. $this->assertEquals(array('foo', 'foo', 'bar'), self::$resolver->getArguments($request, $controller));
  138. }
  139. /**
  140. * @requires PHP 5.6
  141. * @expectedException \InvalidArgumentException
  142. */
  143. public function testGetVariadicArgumentsWithoutArrayInRequest()
  144. {
  145. $request = Request::create('/');
  146. $request->attributes->set('foo', 'foo');
  147. $request->attributes->set('bar', 'foo');
  148. $controller = array(new VariadicController(), 'action');
  149. self::$resolver->getArguments($request, $controller);
  150. }
  151. /**
  152. * @requires PHP 5.6
  153. * @expectedException \InvalidArgumentException
  154. */
  155. public function testGetArgumentWithoutArray()
  156. {
  157. $factory = new ArgumentMetadataFactory();
  158. $valueResolver = $this->getMockBuilder(ArgumentValueResolverInterface::class)->getMock();
  159. $resolver = new ArgumentResolver($factory, array($valueResolver));
  160. $valueResolver->expects($this->any())->method('supports')->willReturn(true);
  161. $valueResolver->expects($this->any())->method('resolve')->willReturn('foo');
  162. $request = Request::create('/');
  163. $request->attributes->set('foo', 'foo');
  164. $request->attributes->set('bar', 'foo');
  165. $controller = array($this, 'controllerWithFooAndDefaultBar');
  166. $resolver->getArguments($request, $controller);
  167. }
  168. /**
  169. * @expectedException \RuntimeException
  170. */
  171. public function testIfExceptionIsThrownWhenMissingAnArgument()
  172. {
  173. $request = Request::create('/');
  174. $controller = array($this, 'controllerWithFoo');
  175. self::$resolver->getArguments($request, $controller);
  176. }
  177. /**
  178. * @requires PHP 7.1
  179. */
  180. public function testGetNullableArguments()
  181. {
  182. $request = Request::create('/');
  183. $request->attributes->set('foo', 'foo');
  184. $request->attributes->set('bar', new \stdClass());
  185. $request->attributes->set('mandatory', 'mandatory');
  186. $controller = array(new NullableController(), 'action');
  187. $this->assertEquals(array('foo', new \stdClass(), 'value', 'mandatory'), self::$resolver->getArguments($request, $controller));
  188. }
  189. /**
  190. * @requires PHP 7.1
  191. */
  192. public function testGetNullableArgumentsWithDefaults()
  193. {
  194. $request = Request::create('/');
  195. $request->attributes->set('mandatory', 'mandatory');
  196. $controller = array(new NullableController(), 'action');
  197. $this->assertEquals(array(null, null, 'value', 'mandatory'), self::$resolver->getArguments($request, $controller));
  198. }
  199. public function __invoke($foo, $bar = null)
  200. {
  201. }
  202. public function controllerWithFoo($foo)
  203. {
  204. }
  205. public function controllerWithoutArguments()
  206. {
  207. }
  208. protected function controllerWithFooAndDefaultBar($foo, $bar = null)
  209. {
  210. }
  211. protected function controllerWithFooBarFoobar($foo, $bar, $foobar)
  212. {
  213. }
  214. protected function controllerWithRequest(Request $request)
  215. {
  216. }
  217. protected function controllerWithExtendingRequest(ExtendingRequest $request)
  218. {
  219. }
  220. }
  221. function controller_function($foo, $foobar)
  222. {
  223. }